NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1632724

committed

amcheck: Fix ordering bug in update_cached_xid_range()

The initialization order in update_cached_xid_range() was wrong, callingFullTransactionIdFromXidAndCtx() before setting->next_xid. FullTransactionIdFromXidAndCtx() uses ->next_xid.In most situations this will not cause visible issues, because the next callto update_cached_xid_range() will use a less wrong ->next_xid. It's rare thatxids advance fast enough for this to be a problem.Found while adding more asserts to the 64bit xid infrastructure.Reviewed-by: Mark Dilger <mark.dilger@enterprisedb.com>Discussion:https://postgr.es/m/20230108002923.cyoser3ttmt63bfn@awork3.anarazel.deBackpatch: 14-, where heapam verification was introduced

1 parent4e63301 commit1632724Copy full SHA for 1632724

File tree

1 file changed

-1

lines changed

contrib/amcheck
- verify_heapam.c

1 file changed

-1

lines changed

`‎contrib/amcheck/verify_heapam.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1576,6 +1576,9 @@ FullTransactionIdFromXidAndCtx(TransactionId xid, const HeapCheckContext *ctx)`
`1576`	`1576`	`{`
`1577`	`1577`	`uint32epoch;`
`1578`	`1578`
	`1579`	`+Assert(TransactionIdIsNormal(ctx->next_xid));`
	`1580`	`+Assert(FullTransactionIdIsNormal(ctx->next_fxid));`
	`1581`	`+`
`1579`	`1582`	`if (!TransactionIdIsNormal(xid))`
`1580`	`1583`	`returnFullTransactionIdFromEpochAndXid(0,xid);`
`1581`	`1584`	`epoch=EpochFromFullTransactionId(ctx->next_fxid);`
`@@ -1597,8 +1600,8 @@ update_cached_xid_range(HeapCheckContext *ctx)`
`1597`	`1600`	`LWLockRelease(XidGenLock);`
`1598`	`1601`
`1599`	`1602`	`/* And compute alternate versions of the same */`
`1600`		`-ctx->oldest_fxid=FullTransactionIdFromXidAndCtx(ctx->oldest_xid,ctx);`
`1601`	`1603`	`ctx->next_xid=XidFromFullTransactionId(ctx->next_fxid);`
	`1604`	`+ctx->oldest_fxid=FullTransactionIdFromXidAndCtx(ctx->oldest_xid,ctx);`
`1602`	`1605`	`}`
`1603`	`1606`
`1604`	`1607`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1632724

File tree

1 file changed

1 file changed

`‎contrib/amcheck/verify_heapam.c`

0 commit comments