NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit15f16ec

committed

Don't duplicate references and libraries in MSVC scripts

In order not to duplicate references and libraries in the Visual Studioproject files produced by the MSVC build scripts, have them check if aparticular reference or library already exists before adding the same oneagain.Reviewed-by: Álvaro Herrera, Andrew Dunstan, Dagfinn Ilmari MannsåkerDiscussion:https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com

1 parent33d74c5 commit15f16ecCopy full SHA for 15f16ec

File tree

1 file changed

-2

lines changed

src/tools/msvc
- Project.pm

1 file changed

-2

lines changed

`‎src/tools/msvc/Project.pm`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,10 @@ sub AddReference`
`124`	`124`
`125`	`125`	`while (my$ref =shift)`
`126`	`126`	`{`
`127`		`-push @{$self->{references} },$ref;`
	`127`	`+if (!grep {$_eq$ref} @{$self->{references} })`
	`128`	`+{`
	`129`	`+push @{$self->{references} },$ref;`
	`130`	`+}`
`128`	`131`	`$self->AddLibrary(`
`129`	`132`	`"__CFGNAME__/" .$ref->{name} ."/" .$ref->{name} .".lib");`
`130`	`133`	`}`
`@@ -141,7 +144,11 @@ sub AddLibrary`
`141`	`144`	`$lib ='"' .$lib .""";`
`142`	`145`	`}`
`143`	`146`
`144`		`-push @{$self->{libraries} },$lib;`
	`147`	`+if (!grep {$_eq$lib} @{$self->{libraries} })`
	`148`	`+{`
	`149`	`+push @{$self->{libraries} },$lib;`
	`150`	`+}`
	`151`	`+`
`145`	`152`	`if ($dbgsuffix)`
`146`	`153`	`{`
`147`	`154`	`push @{$self->{suffixlib} },$lib;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit15f16ec

File tree

1 file changed

1 file changed

`‎src/tools/msvc/Project.pm`

0 commit comments