Commit159bf0f

committed

Remove NULL dereference from RenameRelationInternal().

Defect in last week's commitaac2c9b,per Coverity. Reaching this would need catalog corruption. Back-patchto v12, like that commit.

1 parent7f90b72 commit159bf0fCopy full SHA for 159bf0f

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3893,9 +3893,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal, bo`
`3893`	`3893`	`relrelation = table_open(RelationRelationId, RowExclusiveLock);`
`3894`	`3894`
`3895`	`3895`	`reltup = SearchSysCacheLockedCopy1(RELOID, ObjectIdGetDatum(myrelid));`
`3896`		`-otid = reltup->t_self;`
`3897`	`3896`	`if (!HeapTupleIsValid(reltup))/* shouldn't happen */`
`3898`	`3897`	`elog(ERROR, "cache lookup failed for relation %u", myrelid);`
	`3898`	`+otid = reltup->t_self;`
`3899`	`3899`	`relform = (Form_pg_class) GETSTRUCT(reltup);`
`3900`	`3900`
`3901`	`3901`	`if (get_relname_relid(newrelname, namespaceId) != InvalidOid)`

Comments

(0)