NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1545ca9

committed

Fix unsafe usage of strerror(errno) within ereport().

This is the converse of the unsafe-usage-of-%m problem: the reasonereport/elog provide that format code is mainly to dodge the hazardof errno getting changed before control reaches functions within thearguments of the macro. I only found one instance of this hazard,but it's been there since 9.4 :-(.

1 parent9c515f7 commit1545ca9Copy full SHA for 1545ca9

File tree

1 file changed

-1

lines changed

src/backend/libpq
- auth.c

1 file changed

-1

lines changed

`‎src/backend/libpq/auth.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1752,10 +1752,12 @@ auth_peer(hbaPort *port)`
`1752`	`1752`	`pw=getpwuid(uid);`
`1753`	`1753`	`if (!pw)`
`1754`	`1754`	`{`
	`1755`	`+intsave_errno=errno;`
	`1756`	`+`
`1755`	`1757`	`ereport(LOG,`
`1756`	`1758`	`(errmsg("could not look up local user ID %ld: %s",`
`1757`	`1759`	`(long)uid,`
`1758`		`-errno ?strerror(errno) :_("user does not exist"))));`
	`1760`	`+save_errno ?strerror(save_errno) :_("user does not exist"))));`
`1759`	`1761`	`returnSTATUS_ERROR;`
`1760`	`1762`	`}`
`1761`	`1763`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1545ca9

File tree

1 file changed

1 file changed

`‎src/backend/libpq/auth.c‎`

0 commit comments