NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit152d24f

committed

Fix minor leak in pg_dump

Move allocation to after we check the remote server version, to avoida possible, very minor, memory leak. This makes us more consistentthroughout as most places in pg_dump are done in the same way (due, inpart, to previous fixes like this).Spotted by the Coverity scanner.

1 parenta7e5f7b commit152d24fCopy full SHA for 152d24f

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3602,7 +3602,7 @@ getConversions(Archive fout, int numConversions)`
`3602`	`3602`	`PGresult*res;`
`3603`	`3603`	`intntups;`
`3604`	`3604`	`inti;`
`3605`		`-PQExpBufferquery=createPQExpBuffer();`
	`3605`	`+PQExpBufferquery;`
`3606`	`3606`	`ConvInfo*convinfo;`
`3607`	`3607`	`inti_tableoid;`
`3608`	`3608`	`inti_oid;`
`@@ -3617,6 +3617,8 @@ getConversions(Archive fout, int numConversions)`
`3617`	`3617`	`returnNULL;`
`3618`	`3618`	`}`
`3619`	`3619`
	`3620`	`+query=createPQExpBuffer();`
	`3621`	`+`
`3620`	`3622`	`/*`
`3621`	`3623`	`* find all conversions, including builtin conversions; we filter out`
`3622`	`3624`	`* system-defined conversions at dump-out time.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit152d24f

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments