Commit15269b5

committed

Avoid useless loop overhead in AtEOXact routines when the backend is

compiled with USE_ASSERT_CHECKING but is running with assert_enabled false.

1 parent4568e0f commit15269b5Copy full SHA for 15269b5

File tree

+17

-11

lines changed

+17

-11

lines changed

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.191 2005/08/0803:11:44 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.192 2005/08/0819:44:22 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1067,15 +1067,18 @@ void`
`1067`	`1067`	`AtEOXact_Buffers(boolisCommit)`
`1068`	`1068`	`{`
`1069`	`1069`	`#ifdefUSE_ASSERT_CHECKING`
`1070`		`-inti;`
`1071`		`-`
`1072`		`-for (i=0;i<NBuffers;i++)`
	`1070`	`+if (assert_enabled)`
`1073`	`1071`	`{`
`1074`		`-Assert(PrivateRefCount[i]==0);`
	`1072`	`+inti;`
	`1073`	`+`
	`1074`	`+for (i=0;i<NBuffers;i++)`
	`1075`	`+{`
	`1076`	`+Assert(PrivateRefCount[i]==0);`
	`1077`	`+}`
`1075`	`1078`	`}`
	`1079`	`+#endif`
`1076`	`1080`
`1077`	`1081`	`AtEOXact_LocalBuffers(isCommit);`
`1078`		`-#endif`
`1079`	`1082`
`1080`	`1083`	`/* Make sure we reset the strategy hint in case VACUUM errored out */`
`1081`	`1084`	`StrategyHintVacuum(false);`

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/storage/buffer/localbuf.c,v 1.67 2005/05/29 04:23:04 tgl Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/storage/buffer/localbuf.c,v 1.68 2005/08/08 19:44:22 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -308,11 +308,14 @@ void`
`308`	`308`	`AtEOXact_LocalBuffers(boolisCommit)`
`309`	`309`	`{`
`310`	`310`	`#ifdefUSE_ASSERT_CHECKING`
`311`		`-inti;`
`312`		`-`
`313`		`-for (i=0;i<NLocBuffer;i++)`
	`311`	`+if (assert_enabled)`
`314`	`312`	`{`
`315`		`-Assert(LocalRefCount[i]==0);`
	`313`	`+inti;`
	`314`	`+`
	`315`	`+for (i=0;i<NLocBuffer;i++)`
	`316`	`+{`
	`317`	`+Assert(LocalRefCount[i]==0);`
	`318`	`+}`
`316`	`319`	`}`
`317`	`320`	`#endif`
`318`	`321`	`}`

Comments

(0)