NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit151fb75

committed

pg_standby: Avoid writing one byte beyond the end of the buffer.

Previously, read() might have returned a length equal to the bufferlength, and then the subsequent store to buf[len] would write azero-byte one byte past the end. This doesn't seem likely to bea security issue, but there's some chance it could result inpg_standby misbehaving.Spotted by Coverity; patch by Michael Paquier, reviewed by me.

1 parent741b1b2 commit151fb75Copy full SHA for 151fb75

File tree

1 file changed

-1

lines changed

contrib/pg_standby
- pg_standby.c

1 file changed

-1

lines changed

`‎contrib/pg_standby/pg_standby.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ CheckForExternalTrigger(void)`
`435`	`435`	`return;`
`436`	`436`	`}`
`437`	`437`
`438`		`-if ((len=read(fd,buf,sizeof(buf)))<0)`
	`438`	`+if ((len=read(fd,buf,sizeof(buf)-1))<0)`
`439`	`439`	`{`
`440`	`440`	`fprintf(stderr,"WARNING: could not read \"%s\": %s\n",`
`441`	`441`	`triggerPath,strerror(errno));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit151fb75

File tree

1 file changed

1 file changed

`‎contrib/pg_standby/pg_standby.c`

0 commit comments