Commit1508b57

committed

Fix type of iterator variable in SH_START_ITERATE

Also add comment to make the reasoning behind the Assert() more explicit (perTom).Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.comBackpatch: 11-

1 parentfb0f055 commit1508b57Copy full SHA for 1508b57

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -965,15 +965,14 @@ SH_DELETE_ITEM(SH_TYPE * tb, SH_ELEMENT_TYPE * entry)`
`965`	`965`	`SH_SCOPEvoid`
`966`	`966`	`SH_START_ITERATE(SH_TYPEtb,SH_ITERATORiter)`
`967`	`967`	`{`
`968`		`-inti;`
`969`	`968`	`uint64startelem=PG_UINT64_MAX;`
`970`	`969`
`971`	`970`	`/*`
`972`	`971`	`* Search for the first empty element. As deletions during iterations are`
`973`	`972`	`* supported, we want to start/end at an element that cannot be affected`
`974`	`973`	`* by elements being shifted.`
`975`	`974`	`*/`
`976`		`-for (i=0;i<tb->size;i++)`
	`975`	`+for (uint32i=0;i<tb->size;i++)`
`977`	`976`	`{`
`978`	`977`	`SH_ELEMENT_TYPE*entry=&tb->data[i];`
`979`	`978`
`@@ -984,6 +983,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)`
`984`	`983`	`}`
`985`	`984`	`}`
`986`	`985`
	`986`	`+/* we should have found an empty element */`
`987`	`987`	`Assert(startelem<SH_MAX_SIZE);`
`988`	`988`
`989`	`989`	`/*`

Comments

(0)