NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit14ba9b1

committed

Fix failure to rotate postmaster log file for size reasons on Windows.

When we eliminated "unnecessary" wakeups of the syslogger process, webroke size-based logfile rotation on Windows, because on that platformdata transfer is done in a separate thread. While non-Windows platformswould recheck the output file size after every log message, Windows onlydid so when the control thread woke up for some other reason, which mightbe quite infrequent. Per bug #7814 from Tsunezumi. Back-patch to 9.2where the problem was introduced.Jeff Janes

1 parenta79ae0b commit14ba9b1Copy full SHA for 14ba9b1

File tree

1 file changed

-0

lines changed

src/backend/postmaster
- syslogger.c

1 file changed

-0

lines changed

`‎src/backend/postmaster/syslogger.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1058,6 +1058,15 @@ pipeThread(void *arg)`
`1058`	`1058`	`bytes_in_logbuffer+=bytesRead;`
`1059`	`1059`	`process_pipe_input(logbuffer,&bytes_in_logbuffer);`
`1060`	`1060`	`}`
	`1061`	`+`
	`1062`	`+/*`
	`1063`	`+ * If we've filled the current logfile, nudge the main thread to do a`
	`1064`	`+ * log rotation.`
	`1065`	`+ */`
	`1066`	`+if (Log_RotationSize>0&&`
	`1067`	`+ftell(syslogFile) >=Log_RotationSize*1024L)`
	`1068`	`+SetLatch(&sysLoggerLatch);`
	`1069`	`+`
`1061`	`1070`	`LeaveCriticalSection(&sysloggerSection);`
`1062`	`1071`	`}`
`1063`	`1072`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit14ba9b1

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/syslogger.c`

0 commit comments