NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit14661ba

committed

Replace has_multiple_baserels() with a bitmap test on all_baserels.

Since we added the PlannerInfo.all_baserels set, it's not reallynecessary to grovel over the rangetable to count baserels in thecurrent query. So let's drop has_multiple_baserels() in favorof a bms_membership() test. This might be microscopicallyfaster, but the main point is to remove some unnecessary code.Richard GuoDiscussion:https://postgr.es/m/CAMbWs4_8RcSbbfs1ASZLrMuL0c0EQgXWcoLTQD8swBRY_pQQiA@mail.gmail.com

1 parent98e8974 commit14661baCopy full SHA for 14661ba

File tree

1 file changed

-23

lines changed

src/backend/optimizer/path
- allpaths.c

1 file changed

-23

lines changed

`‎src/backend/optimizer/path/allpaths.c`

Lines changed: 1 addition & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -2190,28 +2190,6 @@ set_dummy_rel_pathlist(RelOptInfo *rel)`
`2190`	`2190`	`set_cheapest(rel);`
`2191`	`2191`	`}`
`2192`	`2192`
`2193`		`-/* quick-and-dirty test to see if any joining is needed */`
`2194`		`-staticbool`
`2195`		`-has_multiple_baserels(PlannerInfo*root)`
`2196`		`-{`
`2197`		`-intnum_base_rels=0;`
`2198`		`-Indexrti;`
`2199`		`-`
`2200`		`-for (rti=1;rti<root->simple_rel_array_size;rti++)`
`2201`		`-{`
`2202`		`-RelOptInfo*brel=root->simple_rel_array[rti];`
`2203`		`-`
`2204`		`-if (brel==NULL)`
`2205`		`-continue;`
`2206`		`-`
`2207`		`-/* ignore RTEs that are "other rels" */`
`2208`		`-if (brel->reloptkind==RELOPT_BASEREL)`
`2209`		`-if (++num_base_rels>1)`
`2210`		`-return true;`
`2211`		`-}`
`2212`		`-return false;`
`2213`		`-}`
`2214`		`-`
`2215`	`2193`	`/*`
`2216`	`2194`	`* find_window_run_conditions`
`2217`	`2195`	`*Determine if 'wfunc' is really a WindowFunc and call its prosupport`
`@@ -2661,7 +2639,7 @@ set_subquery_pathlist(PlannerInfo root, RelOptInfo rel,`
`2661`	`2639`	`root->hasHavingQual\|\|`
`2662`	`2640`	`parse->distinctClause\|\|`
`2663`	`2641`	`parse->sortClause\|\|`
`2664`		`-has_multiple_baserels(root))`
	`2642`	`+bms_membership(root->all_baserels)==BMS_MULTIPLE)`
`2665`	`2643`	`tuple_fraction=0.0;/* default case */`
`2666`	`2644`	`else`
`2667`	`2645`	`tuple_fraction=root->tuple_fraction;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit14661ba

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/allpaths.c`

0 commit comments