NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1420617

committed

Change client-side fsync_fname() to report errors fatally

Given all we have learned about fsync() error handling in the last fewyears, reporting an fsync() error non-fatally is not useful,unless you don't care much about the file, in which case you probablydon't need to use fsync() in the first place.Change fsync_fname() and durable_rename() to exit(1) on fsync() errorsother than those that we specifically chose to ignore.This affects initdb, pg_basebackup, pg_checksums, pg_dump, pg_dumpall,and pg_rewind.Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://www.postgresql.org/message-id/flat/d239d1bd-aef0-ca7c-dc0a-da14bdcf0392%402ndquadrant.com

1 parenta91e2fa commit1420617Copy full SHA for 1420617

File tree

1 file changed

-8

lines changed

src/common
- file_utils.c

1 file changed

-8

lines changed

`‎src/common/file_utils.c`

Lines changed: 6 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,6 @@ static void walkdir(const char *path,`
`51`	`51`	`* fsyncing, and might not have privileges to write at all.`
`52`	`52`	`*`
`53`	`53`	`* serverVersion indicates the version of the server to be fsync'd.`
`54`		`- *`
`55`		`- * Errors are reported but not considered fatal.`
`56`	`54`	`*/`
`57`	`55`	`void`
`58`	`56`	`fsync_pgdata(constchar*pg_data,`
`@@ -250,8 +248,8 @@ pre_sync_fname(const char *fname, bool isdir)`
`250`	`248`	`* fsync_fname -- Try to fsync a file or directory`
`251`	`249`	`*`
`252`	`250`	`* Ignores errors trying to open unreadable files, or trying to fsync`
`253`		`- * directories on systems where that isn't allowed/required.Reports`
`254`		`- *other errors non-fatally.`
	`251`	`+ * directories on systems where that isn't allowed/required.All other errors`
	`252`	`+ *are fatal.`
`255`	`253`	`*/`
`256`	`254`	`int`
`257`	`255`	`fsync_fname(constchar*fname,boolisdir)`
`@@ -294,9 +292,9 @@ fsync_fname(const char *fname, bool isdir)`
`294`	`292`	`*/`
`295`	`293`	`if (returncode!=0&& !(isdir&& (errno==EBADF\|\|errno==EINVAL)))`
`296`	`294`	`{`
`297`		`-pg_log_error("could not fsync file \"%s\": %m",fname);`
	`295`	`+pg_log_fatal("could not fsync file \"%s\": %m",fname);`
`298`	`296`	`(void)close(fd);`
`299`		`-return-1;`
	`297`	`+exit(EXIT_FAILURE);`
`300`	`298`	`}`
`301`	`299`
`302`	`300`	`(void)close(fd);`
`@@ -364,9 +362,9 @@ durable_rename(const char oldfile, const char newfile)`
`364`	`362`	`{`
`365`	`363`	`if (fsync(fd)!=0)`
`366`	`364`	`{`
`367`		`-pg_log_error("could not fsync file \"%s\": %m",newfile);`
	`365`	`+pg_log_fatal("could not fsync file \"%s\": %m",newfile);`
`368`	`366`	`close(fd);`
`369`		`-return-1;`
	`367`	`+exit(EXIT_FAILURE);`
`370`	`368`	`}`
`371`	`369`	`close(fd);`
`372`	`370`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1420617

File tree

1 file changed

1 file changed

`‎src/common/file_utils.c`

0 commit comments