forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit141fd1b
committed
Improve sys/catcache performance.
The following are the individual improvements:1) Avoidance of FunctionCallInfo based function calls, replaced by more efficient functions with a native C argument interface.2) Don't extract columns from a cache entry's tuple whenever matching entries - instead store them as a Datum array. This also allows to get rid of having to build dummy tuples for negative & list entries, and of a hack for dealing with cstring vs. text weirdness.3) Reorder members of catcache.h struct, so imortant entries are more likely to be on one cacheline.4) Allowing the compiler to specialize critical SearchCatCache for a specific number of attributes allows to unroll loops and avoid other nkeys dependant initialization.5) Only initializing the ScanKey when necessary, i.e. catcache misses, greatly reduces cache unnecessary cpu cache misses.6) Split of the cache-miss case from the hash lookup, reducing stack allocations etc in the common case.7) CatCTup and their corresponding heaptuple are allocated in one piece.This results in making cache lookups themselves roughly three times asfast - full-system benchmarks obviously improve less than that.I've also evaluated further techniques:- replace open coded hash with simplehash - the list walk right now shows up in profiles. Unfortunately it's not easy to do so safely as an entry's memory location can change at various times, which doesn't work well with the refcounting and cache invalidation.- Cacheline-aligning CatCTup entries - helps some with performance, but the win isn't big and the code for it is ugly, because the tuples have to be freed as well.- add more proper functions, rather than macros for SearchSysCacheCopyN etc., but right now they don't show up in profiles.The reason the macro wrapper for syscache.c/h have to be changed,rather than just catcache, is that doing otherwise would requireexposing the SysCache array to the outside. That might be a good ideaanyway, but it's for another day.Author: Andres FreundReviewed-By: Robert HaasDiscussion:https://postgr.es/m/20170914061207.zxotvyopetm7lrrp@alap3.anarazel.de1 parenta0247e7 commit141fd1b
File tree
5 files changed
+608
-280
lines changed- src
- backend/utils/cache
- include/utils
- tools/pgindent
5 files changed
+608
-280
lines changed0 commit comments
Comments
(0)