forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit1408d5d
committed
Get rid of useless/dangerous redefinition of bool in ECPG.
pgtypeslib_extern.h contained fallback definitions of "bool", "FALSE",and "TRUE". The latter two are just plain unused, and have been forawhile. The former came into play only if there wasn't a macrodefinition of "bool", which is true only if we aren't using <stdbool.h>.However, it then defined bool as "char"; since commitd26a810 thatconflicts with c.h's desire to use "unsigned char". We'd missed seeingany bad effects of that due to accidental header inclusion order choices,butdddf4cd exposed that it was problematic.To fix, let's just get rid of these definitions. They should not beneeded because everyplace in Postgres should be relying on c.h toprovide a definition for type bool. (Note that despite its name,pgtypeslib_extern.h isn't exposed to any outside code; we don'tinstall it.)This doesn't fully resolve the issue, because ecpglib.h is doingsimilar things, but that seems to require more thought to fix.Back-patch to v12 whered26a810 came in, to forestall any unpleasantsurprises from future back-patched bug fixes.Discussion:https://postgr.es/m/CAA4eK1LmaKO7Du9M9Lo=kxGU8sB6aL8fa3sF6z6d5yYYVe3BuQ@mail.gmail.com1 parent22f6f2c commit1408d5d
1 file changed
+0
-12
lines changedLines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 41 | | |
0 commit comments
Comments
(0)