NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit138c51b

committed

Add missing binary-upgrade guard.

Commit9a974cb arranged forpg_dumpall to preserve tablespace OIDs, but it should only do thatin binary upgrade mode, not all the time.Reported by Christoph Berg.Discussion:http://postgr.es/m/YgjwrkEvNEqoz4Vm@msg.df7cb.de

1 parentf1ac4a7 commit138c51bCopy full SHA for 138c51b

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_dumpall.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_dumpall.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1066,8 +1066,11 @@ dumpTablespaces(PGconn *conn)`
`1066`	`1066`	`/* needed for buildACLCommands() */`
`1067`	`1067`	`fspcname=pg_strdup(fmtId(spcname));`
`1068`	`1068`
`1069`		`-appendPQExpBufferStr(buf,"\n-- For binary upgrade, must preserve pg_tablespace oid\n");`
`1070`		`-appendPQExpBuffer(buf,"SELECT pg_catalog.binary_upgrade_set_next_pg_tablespace_oid('%u'::pg_catalog.oid);\n",spcoid);`
	`1069`	`+if (binary_upgrade)`
	`1070`	`+{`
	`1071`	`+appendPQExpBufferStr(buf,"\n-- For binary upgrade, must preserve pg_tablespace oid\n");`
	`1072`	`+appendPQExpBuffer(buf,"SELECT pg_catalog.binary_upgrade_set_next_pg_tablespace_oid('%u'::pg_catalog.oid);\n",spcoid);`
	`1073`	`+}`
`1071`	`1074`
`1072`	`1075`	`appendPQExpBuffer(buf,"CREATE TABLESPACE %s",fspcname);`
`1073`	`1076`	`appendPQExpBuffer(buf," OWNER %s",fmtId(spcowner));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit138c51b

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dumpall.c`

0 commit comments