NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1370030

committed

Prevent underflow in KeepLogSeg().

The call to XLogGetReplicationSlotMinimumLSN() might return agreater LSN than the one given to the function. Subsequent segmentnumber calculations might then underflow, which could result inunexpected behavior when removing or recyling WAL files. This wasintroduced with max_slot_wal_keep_size inc655077. To fix, skipthe block of code for replication slots if the LSN is greater.Reported-by: Xu XingwangAuthor: Kyotaro HoriguchiReviewed-by: Junwang ZhaoDiscussion:https://postgr.es/m/17903-4288d439dee856c6%40postgresql.orgBackpatch-through: 13

1 parentc74f88c commit1370030Copy full SHA for 1370030

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10037,7 +10037,7 @@ KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo)`
`10037`	`10037`	`* max_slot_wal_keep_size.`
`10038`	`10038`	`*/`
`10039`	`10039`	`keep=XLogGetReplicationSlotMinimumLSN();`
`10040`		`-if (keep!=InvalidXLogRecPtr)`
	`10040`	`+if (keep!=InvalidXLogRecPtr&&keep<recptr)`
`10041`	`10041`	`{`
`10042`	`10042`	`XLByteToSeg(keep,segno,wal_segment_size);`
`10043`	`10043`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1370030

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments