NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit131e545

committed

Fix thinkos in LookupFuncName() for function name lookups

This could trigger valgrind failures when doing ambiguous function namelookups when no arguments are provided by the caller. The problem hasbeen introduced inaefeb68, so backpatch to v10. HEAD is fine thanks tothe refactoring done inbfb456c.Reported-by: Alexander LakhinAuthor: Alexander Lakhin, Michael PaquierDiscussion:https://postgr.es/m/3d068be5-f617-a5ee-99f6-458a407bfd65@gmail.comBackpatch-through: 10

1 parent956611e commit131e545Copy full SHA for 131e545

File tree

1 file changed

-2

lines changed

src/backend/parser
- parse_func.c

1 file changed

-2

lines changed

`‎src/backend/parser/parse_func.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1950,9 +1950,10 @@ LookupFuncName(List funcname, int nargs, const Oid argtypes, bool noError)`
`1950`	`1950`	`errmsg("function name \"%s\" is not unique",`
`1951`	`1951`	`NameListToString(funcname)),`
`1952`	`1952`	`errhint("Specify the argument list to select the function unambiguously.")));`
	`1953`	`+returnInvalidOid;`
`1953`	`1954`	`}`
`1954`		`-else`
`1955`		`-returnclist->oid;`
	`1955`	`+/* Otherwise return the match */`
	`1956`	`+returnclist->oid;`
`1956`	`1957`	`}`
`1957`	`1958`	`else`
`1958`	`1959`	`{`
`@@ -1961,9 +1962,14 @@ LookupFuncName(List funcname, int nargs, const Oid argtypes, bool noError)`
`1961`	`1962`	`(errcode(ERRCODE_UNDEFINED_FUNCTION),`
`1962`	`1963`	`errmsg("could not find a function named \"%s\"",`
`1963`	`1964`	`NameListToString(funcname))));`
	`1965`	`+returnInvalidOid;`
`1964`	`1966`	`}`
`1965`	`1967`	`}`
`1966`	`1968`
	`1969`	`+/*`
	`1970`	`+ * Otherwise, look for a match to the arg types. FuncnameGetCandidates`
	`1971`	`+ * has ensured that there's at most one match in the returned list.`
	`1972`	`+ */`
`1967`	`1973`	`while (clist)`
`1968`	`1974`	`{`
`1969`	`1975`	`if (memcmp(argtypes,clist->args,nargs*sizeof(Oid))==0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit131e545

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_func.c`

0 commit comments