Commit131926a

committed

Remove useless check for NULL subexpression.

Coverity rightly gripes that it's silly to have a test here whenthe adjacent ExecEvalExpr() would choke on a NULL expression pointer.Petr Jelinek

1 parent302ac7f commit131926aCopy full SHA for 131926a

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,19 +103,13 @@ tablesample_init(SampleScanState scanstate, TableSampleClause tablesample)`
`103`	`103`	`fcinfo.argnull[1]= false;`
`104`	`104`	`}`
`105`	`105`
`106`		`-/* Rest of the arguments come from user.*/`
	`106`	`+/* Rest of the arguments come from user. */`
`107`	`107`	`i=2;`
`108`	`108`	`foreach(arg,args)`
`109`	`109`	`{`
`110`	`110`	`Exprargexpr= (Expr)lfirst(arg);`
`111`	`111`	`ExprStateargstate=ExecInitExpr(argexpr, (PlanState)scanstate);`
`112`	`112`
`113`		`-if (argstate==NULL)`
`114`		`-{`
`115`		`-fcinfo.argnull[i]= true;`
`116`		`-fcinfo.arg[i]= (Datum)0;;`
`117`		`-}`
`118`		`-`
`119`	`113`	`fcinfo.arg[i]=ExecEvalExpr(argstate,econtext,`
`120`	`114`	`&fcinfo.argnull[i],NULL);`
`121`	`115`	`i++;`

Comments

(0)