NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit12f8620

committed

Fix regression test for force_parallel_mode=on.

Commit14a254f managed not toexercise the code it was intended to test, and the comment explainingwhy no "parallel worker" line showed up in the context wasn't right.Amit Kapila, tweaked by me per Amit's analysis.

1 parente472ce9 commit12f8620Copy full SHA for 12f8620

File tree

2 files changed

+12

-9

lines changed

src/test/regress
- expected
  - select_parallel.out
- sql
  - select_parallel.sql

2 files changed

+12

-9

lines changed

`‎src/test/regress/expected/select_parallel.out`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,12 @@ explain (costs off)`
`44`	`44`
`45`	`45`	`do $$begin`
`46`	`46`	`-- Provoke error in worker. The original message CONTEXT contains a worker`
`47`		`- -- PID that must be hidden in the test output. PL/pgSQL conveniently`
`48`		`- -- substitutes its own CONTEXT.`
`49`		`- select stringu1::int2 from tenk1 where unique1 = 1;`
	`47`	`+ -- PID that must be hidden in the test output.`
	`48`	`+ perform stringu1::int2 from tenk1 where unique1 = 1;`
	`49`	`+ exception`
	`50`	`+when others then`
	`51`	`+raise 'SQLERRM: %', sqlerrm;`
`50`	`52`	`end$$;`
`51`		`-ERROR: invalid input syntax for integer: "BAAAAA"`
`52`		`-CONTEXT: SQL statement "select stringu1::int2 from tenk1 where unique1 = 1"`
`53`		`-PL/pgSQL function inline_code_block line 5 at SQL statement`
	`53`	`+ERROR: SQLERRM: invalid input syntax for integer: "BAAAAA"`
	`54`	`+CONTEXT: PL/pgSQL function inline_code_block line 7 at RAISE`
`54`	`55`	`rollback;`

`‎src/test/regress/sql/select_parallel.sql`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,11 @@ explain (costs off)`
`21`	`21`
`22`	`22`	`do $$begin`
`23`	`23`	`-- Provoke error in worker. The original message CONTEXT contains a worker`
`24`		`--- PID that must be hidden in the test output. PL/pgSQL conveniently`
`25`		`--- substitutes its own CONTEXT.`
`26`		`-select stringu1::int2from tenk1where unique1=1;`
	`24`	`+-- PID that must be hidden in the test output.`
	`25`	`+ perform stringu1::int2from tenk1where unique1=1;`
	`26`	`+ exception`
	`27`	`+when others then`
	`28`	`+raise'SQLERRM: %', sqlerrm;`
`27`	`29`	`end$$;`
`28`	`30`
`29`	`31`	`rollback;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit12f8620

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/select_parallel.out`

`‎src/test/regress/sql/select_parallel.sql`

0 commit comments