Commit12e28aa

committed

Add debugging help in OwnLatch().

Build farm animal gharial recently failed a few times in a parallelworker's call to OwnLatch() with "ERROR: latch already owned". Let'sturn that into a PANIC and show the PID of the owner, to try to learnmore.Discussion:https://postgr.es/m/CA%2BhUKGJ_0RGcr7oUNzcHdn7zHqHSB_wLSd3JyS2YC_DYB%2B-V%3Dg%40mail.gmail.com

1 parent5f0adec commit12e28aaCopy full SHA for 12e28aa

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -402,6 +402,8 @@ InitSharedLatch(Latch *latch)`
`402`	`402`	`void`
`403`	`403`	`OwnLatch(Latch*latch)`
`404`	`404`	`{`
	`405`	`+intowner_pid;`
	`406`	`+`
`405`	`407`	`/* Sanity checks */`
`406`	`408`	`Assert(latch->is_shared);`
`407`	`409`
`@@ -410,8 +412,9 @@ OwnLatch(Latch *latch)`
`410`	`412`	`Assert(selfpipe_readfd >=0&&selfpipe_owner_pid==MyProcPid);`
`411`	`413`	`#endif`
`412`	`414`
`413`		`-if (latch->owner_pid!=0)`
`414`		`-elog(ERROR,"latch already owned");`
	`415`	`+owner_pid=latch->owner_pid;`
	`416`	`+if (owner_pid!=0)`
	`417`	`+elog(PANIC,"latch already owned by PID %d",owner_pid);`
`415`	`418`
`416`	`419`	`latch->owner_pid=MyProcPid;`
`417`	`420`	`}`

Comments

(0)