NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit129a2f6

committed

Fix incorrect pg_stat_io output on 32-bit machines.

pg_stat_get_io() applied TimestampTzGetDatum twice to thestat_reset_timestamp value. On 64-bit builds that's harmless becauseTimestampTzGetDatum is a no-op, but on 32-bit builds it results indisplaying garbage in the stats_reset column of the pg_stat_io view.Bug dates to commita9c70b4 which introduced pg_stat_io, soback-patch to v16 where that came in.Bertrand DrouvotDiscussion:https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal

1 parent9e43ab3 commit129a2f6Copy full SHA for 129a2f6

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- pgstatfuncs.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/pgstatfuncs.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1408,7 +1408,7 @@ pg_stat_get_io(PG_FUNCTION_ARGS)`
`1408`	`1408`	`values[IO_COL_BACKEND_TYPE]=bktype_desc;`
`1409`	`1409`	`values[IO_COL_CONTEXT]=CStringGetTextDatum(context_name);`
`1410`	`1410`	`values[IO_COL_OBJECT]=CStringGetTextDatum(obj_name);`
`1411`		`-values[IO_COL_RESET_TIME]=TimestampTzGetDatum(reset_time);`
	`1411`	`+values[IO_COL_RESET_TIME]=reset_time;`
`1412`	`1412`
`1413`	`1413`	`/*`
`1414`	`1414`	`* Hard-code this to the value of BLCKSZ for now. Future`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit129a2f6

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/pgstatfuncs.c`

0 commit comments