Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit128e9b2

Browse files
committed
Fix failure of --jobs with vacuumdb on Windows
FD_SETSIZE needs to be declared before winsock2.h, or it is possible torun into buffer overflow issues when using --jobs. This is similar topgbench's solution done ina23c641.This has been introduced by71d84ef, and older versions have been usingthe default value of FD_SETSIZE, defined at 64. While on it, add amissing newline to the previously-added error message.Per buildfarm member jacana, but this impacts all Windows animalsrunning the TAP tests. I have reproduced the failure locally to checkthe patch.Author: Michael PaquierReviewed-by: Andrew DunstanDiscussion:https://postgr.es/m/20190826054000.GE7005@paquier.xyzBackpatch-through: 9.5
1 parentad9b419 commit128e9b2

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

‎src/bin/scripts/vacuumdb.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
*-------------------------------------------------------------------------
1111
*/
1212

13+
#ifdefWIN32
14+
#defineFD_SETSIZE 1024/* must set before winsock2.h is included */
15+
#endif
16+
1317
#include"postgres_fe.h"
1418

1519
#ifdefHAVE_SYS_SELECT_H
@@ -445,7 +449,7 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
445449
if (PQsocket(conn) >=FD_SETSIZE)
446450
{
447451
fprintf(stderr,
448-
_("%s: too many jobs for this platform -- try %d"),
452+
_("%s: too many jobs for this platform -- try %d\n"),
449453
progname,i);
450454
exit(1);
451455
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp