Commit11d40a4

committed

Throw a more on-point error for publications depending on columns.

Same as42b0412, except that the trouble case is a publicationWHERE clause that depends on a column.Again reported by Alexander Lakhin. Back-patch to v15 wherewe added publication WHERE clauses.Discussion:https://postgr.es/m/548a47bc-87ae-b3df-c6a2-60b9966f808b@gmail.com

1 parentec235d8 commit11d40a4Copy full SHA for 11d40a4

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12843,6 +12843,20 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`12843`	`12843`	`RememberStatisticsForRebuilding(foundObject.objectId, tab);`
`12844`	`12844`	`break;`
`12845`	`12845`
	`12846`	`+case OCLASS_PUBLICATION_REL:`
	`12847`	`+`
	`12848`	`+/*`
	`12849`	`+ * Column reference in a PUBLICATION ... FOR TABLE ... WHERE`
	`12850`	`+ * clause. Same issues as above. FIXME someday.`
	`12851`	`+ */`
	`12852`	`+ereport(ERROR,`
	`12853`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`12854`	`+ errmsg("cannot alter type of a column used by a publication WHERE clause"),`
	`12855`	`+ errdetail("%s depends on column \"%s\"",`
	`12856`	`+ getObjectDescription(&foundObject, false),`
	`12857`	`+ colName)));`
	`12858`	`+break;`
	`12859`	`+`
`12846`	`12860`	`case OCLASS_TYPE:`
`12847`	`12861`	`case OCLASS_CAST:`
`12848`	`12862`	`case OCLASS_COLLATION:`
`@@ -12873,7 +12887,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`12873`	`12887`	`case OCLASS_PARAMETER_ACL:`
`12874`	`12888`	`case OCLASS_PUBLICATION:`
`12875`	`12889`	`case OCLASS_PUBLICATION_NAMESPACE:`
`12876`		`-case OCLASS_PUBLICATION_REL:`
`12877`	`12890`	`case OCLASS_SUBSCRIPTION:`
`12878`	`12891`	`case OCLASS_TRANSFORM:`
`12879`	`12892`

Comments

(0)