Commit11b09d2

Amit Kapila

authored and

pull[bot]

committed

Avoid creating parallel apply state hash table unless required.

This hash table is used to cache the state of streaming transactions beingapplied by the parallel apply workers. So, this should be created onlywhen we are successful in launching at least one worker. This avoids rarecase memory leak when we are never able to launch any worker.Author: Ted YuDiscussion:https://postgr.es/m/CALte62wg0rBR3Vj2beV=HiWo2qG9L0hzKcX=yULNER0wmf4aEw@mail.gmail.com

1 parentdf47666 commit11b09d2Copy full SHA for 11b09d2

File tree

1 file changed

-4

lines changed

src/backend/replication/logical
- applyparallelworker.c

1 file changed

-4

lines changed

`‎src/backend/replication/logical/applyparallelworker.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -475,6 +475,10 @@ pa_allocate_worker(TransactionId xid)`
`475`	`475`	`if (!pa_can_start())`
`476`	`476`	`return;`
`477`	`477`
	`478`	`+winfo=pa_launch_parallel_worker();`
	`479`	`+if (!winfo)`
	`480`	`+return;`
	`481`	`+`
`478`	`482`	`/* First time through, initialize parallel apply worker state hashtable. */`
`479`	`483`	`if (!ParallelApplyTxnHash)`
`480`	`484`	`{`
`@@ -490,10 +494,6 @@ pa_allocate_worker(TransactionId xid)`
`490`	`494`	`HASH_ELEM \|HASH_BLOBS \|HASH_CONTEXT);`
`491`	`495`	`}`
`492`	`496`
`493`		`-winfo=pa_launch_parallel_worker();`
`494`		`-if (!winfo)`
`495`		`-return;`
`496`		`-`
`497`	`497`	`/* Create an entry for the requested transaction. */`
`498`	`498`	`entry=hash_search(ParallelApplyTxnHash,&xid,HASH_ENTER,&found);`
`499`	`499`	`if (found)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit11b09d2

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/applyparallelworker.c`

0 commit comments