NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1171dbd

committed

Fix incorrect return value in JSON equality function for scalars

equalsJsonbScalarValue() uses a boolean as return type, however for onecode path -1 gets returned, which is confusing. The origin of theconfusion is visibly that this code got copy-pasted fromcompareJsonbScalarValue() since it has been introduced ind1d50bf.No backpatch, as this is only cosmetic.Author: Rikard FalkebornDiscussion:https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com

1 parent8a29ed0 commit1171dbdCopy full SHA for 1171dbd

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- jsonb_util.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/jsonb_util.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1318,7 +1318,7 @@ equalsJsonbScalarValue(JsonbValue aScalar, JsonbValue bScalar)`
`1318`	`1318`	`}`
`1319`	`1319`	`}`
`1320`	`1320`	`elog(ERROR,"jsonb scalar type mismatch");`
`1321`		`-return-1;`
	`1321`	`+returnfalse;`
`1322`	`1322`	`}`
`1323`	`1323`
`1324`	`1324`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1171dbd

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonb_util.c`

0 commit comments