NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit10fcfad

committed

Don't wait for the commit record to be replicated if we wrote no WAL.

When using synchronous replication, we waited for the commit record to bereplicated, but if we our transaction didn't write any other WAL records,that's not required because we don't even flush the WAL locally to disk inthat case. This lead to long waits when committing a transaction that onlymodified a temporary table. Bug spotted by Thom Brown.

1 parent7985398 commit10fcfadCopy full SHA for 10fcfad

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xact.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xact.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1141,7 +1141,8 @@ RecordTransactionCommit(void)`
`1141`	`1141`	`* Note that at this stage we have marked clog, but still show as running`
`1142`	`1142`	`* in the procarray and continue to hold locks.`
`1143`	`1143`	`*/`
`1144`		`-SyncRepWaitForLSN(XactLastRecEnd);`
	`1144`	`+if (wrote_xlog)`
	`1145`	`+SyncRepWaitForLSN(XactLastRecEnd);`
`1145`	`1146`
`1146`	`1147`	`/* Reset XactLastRecEnd until the next transaction writes something */`
`1147`	`1148`	`XactLastRecEnd.xrecoff=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit10fcfad

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xact.c`

0 commit comments