NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit10eae82

committed

Fix thinko in assertion in basebackup.c.

Commit5a1007a tried to introducean assertion that the block size was at least twice the size of atar block, but I got the math wrong. My error was reported to meoff-list.

1 parenta27048c commit10eae82Copy full SHA for 10eae82

File tree

1 file changed

-2

lines changed

src/backend/replication
- basebackup.c

1 file changed

-2

lines changed

`‎src/backend/replication/basebackup.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ perform_base_backup(basebackup_options opt, bbsink sink)`
`376`	`376`	`else`
`377`	`377`	`{`
`378`	`378`	`/* Properly terminate the tarfile. */`
`379`		`-StaticAssertStmt(TAR_BLOCK_SIZE <=2*BLCKSZ,`
	`379`	`+StaticAssertStmt(2*TAR_BLOCK_SIZE <=BLCKSZ,`
`380`	`380`	`"BLCKSZ too small for 2 tar blocks");`
`381`	`381`	`memset(sink->bbs_buffer,0,2*TAR_BLOCK_SIZE);`
`382`	`382`	`bbsink_archive_contents(sink,2*TAR_BLOCK_SIZE);`
`@@ -621,7 +621,7 @@ perform_base_backup(basebackup_options opt, bbsink sink)`
`621`	`621`	`}`
`622`	`622`
`623`	`623`	`/* Properly terminate the tar file. */`
`624`		`-StaticAssertStmt(TAR_BLOCK_SIZE <=2*BLCKSZ,`
	`624`	`+StaticAssertStmt(2*TAR_BLOCK_SIZE <=BLCKSZ,`
`625`	`625`	`"BLCKSZ too small for 2 tar blocks");`
`626`	`626`	`memset(sink->bbs_buffer,0,2*TAR_BLOCK_SIZE);`
`627`	`627`	`bbsink_archive_contents(sink,2*TAR_BLOCK_SIZE);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit10eae82

File tree

1 file changed

1 file changed

`‎src/backend/replication/basebackup.c‎`

0 commit comments