Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit10e3acb

Browse files
committed
Prevent synchronous scan during GIN index build, because GIN is optimized
for inserting tuples in increasing TID order. It's not clear whether thisfully explains Ivan Sergio Borgonovo's complaint, but simple testingconfirms that a scan that doesn't start at block 0 can slow GIN build bya factor of three or four.Backpatch to 8.3. Sync scan didn't exist before that.
1 parent3379fae commit10e3acb

File tree

6 files changed

+22
-12
lines changed

6 files changed

+22
-12
lines changed

‎src/backend/access/gin/gininsert.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
1010
* IDENTIFICATION
11-
*$PostgreSQL: pgsql/src/backend/access/gin/gininsert.c,v 1.15 2008/09/30 10:52:10 heikki Exp $
11+
*$PostgreSQL: pgsql/src/backend/access/gin/gininsert.c,v 1.16 2008/11/13 17:42:09 tgl Exp $
1212
*-------------------------------------------------------------------------
1313
*/
1414

@@ -340,8 +340,11 @@ ginbuild(PG_FUNCTION_ARGS)
340340
buildstate.accum.ginstate=&buildstate.ginstate;
341341
ginInitBA(&buildstate.accum);
342342

343-
/* do the heap scan */
344-
reltuples=IndexBuildHeapScan(heap,index,indexInfo,
343+
/*
344+
* Do the heap scan. We disallow sync scan here because dataPlaceToPage
345+
* prefers to receive tuples in TID order.
346+
*/
347+
reltuples=IndexBuildHeapScan(heap,index,indexInfo, false,
345348
ginBuildCallback, (void*)&buildstate);
346349

347350
/* dump remaining entries to the index */

‎src/backend/access/gist/gist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/gist/gist.c,v 1.153 2008/11/03 20:47:48 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/gist/gist.c,v 1.154 2008/11/13 17:42:09 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -152,7 +152,7 @@ gistbuild(PG_FUNCTION_ARGS)
152152
buildstate.tmpCtx=createTempGistContext();
153153

154154
/* do the heap scan */
155-
reltuples=IndexBuildHeapScan(heap,index,indexInfo,
155+
reltuples=IndexBuildHeapScan(heap,index,indexInfo, true,
156156
gistbuildCallback, (void*)&buildstate);
157157

158158
/* okay, all heap tuples are indexed */

‎src/backend/access/hash/hash.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/hash/hash.c,v 1.106 2008/10/17 23:50:57 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/hash/hash.c,v 1.107 2008/11/13 17:42:10 tgl Exp $
1212
*
1313
* NOTES
1414
* This file contains only the public interface routines.
@@ -93,7 +93,7 @@ hashbuild(PG_FUNCTION_ARGS)
9393
buildstate.indtuples=0;
9494

9595
/* do the heap scan */
96-
reltuples=IndexBuildHeapScan(heap,index,indexInfo,
96+
reltuples=IndexBuildHeapScan(heap,index,indexInfo, true,
9797
hashbuildCallback, (void*)&buildstate);
9898

9999
if (buildstate.spool)

‎src/backend/access/nbtree/nbtree.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* Portions Copyright (c) 1994, Regents of the University of California
1313
*
1414
* IDENTIFICATION
15-
* $PostgreSQL: pgsql/src/backend/access/nbtree/nbtree.c,v 1.164 2008/10/31 15:04:59 heikki Exp $
15+
* $PostgreSQL: pgsql/src/backend/access/nbtree/nbtree.c,v 1.165 2008/11/13 17:42:10 tgl Exp $
1616
*
1717
*-------------------------------------------------------------------------
1818
*/
@@ -122,7 +122,7 @@ btbuild(PG_FUNCTION_ARGS)
122122
buildstate.spool2=_bt_spoolinit(index, false, true);
123123

124124
/* do the heap scan */
125-
reltuples=IndexBuildHeapScan(heap,index,indexInfo,
125+
reltuples=IndexBuildHeapScan(heap,index,indexInfo, true,
126126
btbuildCallback, (void*)&buildstate);
127127

128128
/* okay, all heap tuples are indexed */

‎src/backend/catalog/index.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.307 2008/11/02 01:45:27 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.308 2008/11/13 17:42:10 tgl Exp $
1212
*
1313
*
1414
* INTERFACE ROUTINES
@@ -1513,6 +1513,7 @@ double
15131513
IndexBuildHeapScan(RelationheapRelation,
15141514
RelationindexRelation,
15151515
IndexInfo*indexInfo,
1516+
boolallow_sync,
15161517
IndexBuildCallbackcallback,
15171518
void*callback_state)
15181519
{
@@ -1575,7 +1576,12 @@ IndexBuildHeapScan(Relation heapRelation,
15751576
OldestXmin=GetOldestXmin(heapRelation->rd_rel->relisshared, true);
15761577
}
15771578

1578-
scan=heap_beginscan(heapRelation,snapshot,0,NULL);
1579+
scan=heap_beginscan_strat(heapRelation,/* relation */
1580+
snapshot,/* snapshot */
1581+
0,/* number of keys */
1582+
NULL,/* scan key */
1583+
true,/* buffer access strategy OK */
1584+
allow_sync);/* syncscan OK? */
15791585

15801586
reltuples=0;
15811587

‎src/include/catalog/index.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $PostgreSQL: pgsql/src/include/catalog/index.h,v 1.75 2008/01/01 19:45:56 momjian Exp $
10+
* $PostgreSQL: pgsql/src/include/catalog/index.h,v 1.76 2008/11/13 17:42:10 tgl Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -63,6 +63,7 @@ extern void index_build(Relation heapRelation,
6363
externdoubleIndexBuildHeapScan(RelationheapRelation,
6464
RelationindexRelation,
6565
IndexInfo*indexInfo,
66+
boolallow_sync,
6667
IndexBuildCallbackcallback,
6768
void*callback_state);
6869

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp