Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit10b81fb

Browse files
committed
Guard against bad "dscale" values in numeric_recv().
We were not checking to see if the supplied dscale was valid for the givendigit array when receiving binary-format numeric values. While dscale canvalidly be more than the number of nonzero fractional digits, it shouldn'tbe less; that case causes fractional digits to be hidden on display eventhough they're there and participate in arithmetic.Bug #12053 from Tommaso Sala indicates that there's at least one brokenclient library out there that sometimes supplies an incorrect dscale value,leading to strange behavior. This suggests that simply throwing an errormight not be the best response; it would lead to failures in applicationsthat might seem to be working fine today. What seems the least risky fixis to truncate away any digits that would be hidden by dscale. Thispreserves the existing behavior in terms of what will be printed for thetransmitted value, while preventing subsequent arithmetic from producingresults inconsistent with that.In passing, throw a specific error for the case of dscale being outsidethe range that will fit into a numeric's header. Before you got "valueoverflows numeric format", which is a bit misleading.Back-patch to all supported branches.
1 parent9e05f3b commit10b81fb

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

‎src/backend/utils/adt/numeric.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -657,6 +657,8 @@ numeric_recv(PG_FUNCTION_ARGS)
657657
alloc_var(&value,len);
658658

659659
value.weight= (int16)pq_getmsgint(buf,sizeof(int16));
660+
/* we allow any int16 for weight --- OK? */
661+
660662
value.sign= (uint16)pq_getmsgint(buf,sizeof(uint16));
661663
if (!(value.sign==NUMERIC_POS||
662664
value.sign==NUMERIC_NEG||
@@ -666,6 +668,11 @@ numeric_recv(PG_FUNCTION_ARGS)
666668
errmsg("invalid sign in external \"numeric\" value")));
667669

668670
value.dscale= (uint16)pq_getmsgint(buf,sizeof(uint16));
671+
if ((value.dscale&NUMERIC_DSCALE_MASK)!=value.dscale)
672+
ereport(ERROR,
673+
(errcode(ERRCODE_INVALID_BINARY_REPRESENTATION),
674+
errmsg("invalid scale in external \"numeric\" value")));
675+
669676
for (i=0;i<len;i++)
670677
{
671678
NumericDigitd=pq_getmsgint(buf,sizeof(NumericDigit));
@@ -677,6 +684,14 @@ numeric_recv(PG_FUNCTION_ARGS)
677684
value.digits[i]=d;
678685
}
679686

687+
/*
688+
* If the given dscale would hide any digits, truncate those digits away.
689+
* We could alternatively throw an error, but that would take a bunch of
690+
* extra code (about as much as trunc_var involves), and it might cause
691+
* client compatibility issues.
692+
*/
693+
trunc_var(&value,value.dscale);
694+
680695
apply_typmod(&value,typmod);
681696

682697
res=make_result(&value);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp