Commit10a5992

committed

Fix comment about ressortgrouprefs being unique in setop plans.

1 parentf36b636 commit10a5992Copy full SHA for 10a5992

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2936,7 +2936,14 @@ search_indexed_tlist_for_sortgroupref(Expr *node,`
`2936`	`2936`	`{`
`2937`	`2937`	`TargetEntrytle= (TargetEntry)lfirst(lc);`
`2938`	`2938`
`2939`		`-/* The equal() check should be redundant, but let's be paranoid */`
	`2939`	`+/*`
	`2940`	`+ * Usually the equal() check is redundant, but in setop plans it may`
	`2941`	`+ * not be, since prepunion.c assigns ressortgroupref equal to the`
	`2942`	`+ * column resno without regard to whether that matches the topmost`
	`2943`	`+ * level's sortgrouprefs and without regard to whether any implicit`
	`2944`	`+ * coercions are added in the setop tree. We might have to clean that`
	`2945`	`+ * up someday; but for now, just ignore any false matches.`
	`2946`	`+ */`
`2940`	`2947`	`if (tle->ressortgroupref==sortgroupref&&`
`2941`	`2948`	`equal(node,tle->expr))`
`2942`	`2949`	`{`

Comments

(0)