NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit108a0ec

committed

A little further progress on schemas: push down RangeVars into

addRangeTableEntry calls. Remove relname field from RTEs, sinceit will no longer be a useful unique identifier of relations;we want to encourage people to rely on the relation OID instead.Further work on dumping qual expressions in EXPLAIN, too.

1 parent56c9b73 commit108a0ecCopy full SHA for 108a0ec

File tree

33 files changed

+495

-311

lines changed

src
- backend
  - catalog
    - heap.c
  - commands
  - nodes
  - optimizer/prep
    - prepunion.c
  - parser
  - rewrite
    - rewriteHandler.c
  - tcop
    - postgres.c
    - utility.c
  - utils
    - adt
      - ruleutils.c
    - cache
      - lsyscache.c
- include
  - catalog
    - catversion.h
  - commands
    - creatinh.h
  - nodes
  - parser
    - parse_clause.h
    - parse_relation.h
  - utils
    - builtins.h
    - lsyscache.h

33 files changed

+495

-311

lines changed

`‎src/backend/catalog/heap.c`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.190 2002/03/21 16:00:29 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.191 2002/03/22 02:56:30 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -45,6 +45,7 @@`
`45`	`45`	`#include"commands/comment.h"`
`46`	`46`	`#include"commands/trigger.h"`
`47`	`47`	`#include"miscadmin.h"`
	`48`	`+#include"nodes/makefuncs.h"`
`48`	`49`	`#include"optimizer/clauses.h"`
`49`	`50`	`#include"optimizer/planmain.h"`
`50`	`51`	`#include"optimizer/prep.h"`
`@@ -1612,7 +1613,11 @@ AddRelationRawConstraints(Relation rel,`
`1612`	`1613`	`* sole rangetable entry. We need a ParseState for transformExpr.`
`1613`	`1614`	`*/`
`1614`	`1615`	`pstate=make_parsestate(NULL);`
`1615`		`-rte=addRangeTableEntry(pstate,relname,NULL, false, true);`
	`1616`	`+rte=addRangeTableEntryForRelation(pstate,`
	`1617`	`+RelationGetRelid(rel),`
	`1618`	`+makeAlias(relname,NIL),`
	`1619`	`+false,`
	`1620`	`+true);`
`1616`	`1621`	`addRTEtoQuery(pstate,rte, true, true);`
`1617`	`1622`
`1618`	`1623`	`/*`

`‎src/backend/commands/command.c`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.163 2002/03/21 23:27:20 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.164 2002/03/22 02:56:31 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* The PerformAddAttribute() code, like most of the relation`
`@@ -37,6 +37,7 @@`
`37`	`37`	`#include"executor/execdefs.h"`
`38`	`38`	`#include"executor/executor.h"`
`39`	`39`	`#include"miscadmin.h"`
	`40`	`+#include"nodes/makefuncs.h"`
`40`	`41`	`#include"optimizer/clauses.h"`
`41`	`42`	`#include"optimizer/planmain.h"`
`42`	`43`	`#include"optimizer/prep.h"`
`@@ -1262,8 +1263,11 @@ AlterTableAddConstraint(char *relationName,`
`1262`	`1263`	`* expression we can pass to ExecQual`
`1263`	`1264`	`*/`
`1264`	`1265`	`pstate=make_parsestate(NULL);`
`1265`		`-rte=addRangeTableEntry(pstate,relationName,NULL,`
`1266`		`- false, true);`
	`1266`	`+rte=addRangeTableEntryForRelation(pstate,`
	`1267`	`+myrelid,`
	`1268`	`+makeAlias(relationName,NIL),`
	`1269`	`+false,`
	`1270`	`+true);`
`1267`	`1271`	`addRTEtoQuery(pstate,rte, true, true);`
`1268`	`1272`
`1269`	`1273`	`/*`

`‎src/backend/commands/creatinh.c`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/creatinh.c,v 1.90 2002/03/21 23:27:20 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/creatinh.c,v 1.91 2002/03/22 02:56:31 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -46,9 +46,11 @@ static List MergeDomainAttributes(List schema);`
`46`	`46`	`/* ----------------------------------------------------------------`
`47`	`47`	`*DefineRelation`
`48`	`48`	`*Creates a new relation.`
	`49`	`+ *`
	`50`	`+ * If successful, returns the OID of the new relation.`
`49`	`51`	`* ----------------------------------------------------------------`
`50`	`52`	`*/`
`51`		`-void`
	`53`	`+Oid`
`52`	`54`	`DefineRelation(CreateStmt*stmt,charrelkind)`
`53`	`55`	`{`
`54`	`56`	`char*relname=palloc(NAMEDATALEN);`
`@@ -165,7 +167,7 @@ DefineRelation(CreateStmt *stmt, char relkind)`
`165`	`167`	`* see the new rel anyway until we commit), but it keeps the lock`
`166`	`168`	`* manager from complaining about deadlock risks.`
`167`	`169`	`*/`
`168`		`-rel=heap_openr(relname,AccessExclusiveLock);`
	`170`	`+rel=heap_open(relationId,AccessExclusiveLock);`
`169`	`171`
`170`	`172`	`/*`
`171`	`173`	`* Now add any newly specified column default values and CHECK`
`@@ -210,11 +212,13 @@ DefineRelation(CreateStmt *stmt, char relkind)`
`210`	`212`	`* visible to anyone else anyway, until commit).`
`211`	`213`	`*/`
`212`	`214`	`heap_close(rel,NoLock);`
	`215`	`+`
	`216`	`+returnrelationId;`
`213`	`217`	`}`
`214`	`218`
`215`	`219`	`/*`
`216`	`220`	`* RemoveRelation`
`217`		`- *Deletes anewrelation.`
	`221`	`+ *Deletes a relation.`
`218`	`222`	`*`
`219`	`223`	`* Exceptions:`
`220`	`224`	`*BadArg if name is invalid.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit108a0ec

File tree

33 files changed

33 files changed

`‎src/backend/catalog/heap.c`

`‎src/backend/commands/command.c`

`‎src/backend/commands/creatinh.c`

0 commit comments