NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit106f26a

committed

Avoid using atooid for numerical comparisons which arent Oids

The check for the number of roles in the target cluster for an upgradeselects the existing roles and performs a COUNT(*) over the result. Avalue of one is the expected query result value indicating that onlythe install user is present in the new cluster. The result was convertedwith the function for converting a string containing an Oid into a numeric,which avoids potential overflow but makes the code less readable sinceit's not actually an Oid at all.Discussion:https://postgr.es/m/41AB5F1F-4389-4B25-9668-5C430375836C@yesql.se

1 parent4c8044c commit106f26aCopy full SHA for 106f26a

File tree

1 file changed

-1

lines changed

src/bin/pg_upgrade
- check.c

1 file changed

-1

lines changed

`‎src/bin/pg_upgrade/check.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ check_is_install_user(ClusterInfo *cluster)`
`568`	`568`	`* users might match users defined in the old cluster and generate an`
`569`	`569`	`* error during pg_dump restore.`
`570`	`570`	`*/`
`571`		`-if (cluster==&new_cluster&&atooid(PQgetvalue(res,0,0))!=1)`
	`571`	`+if (cluster==&new_cluster&&strcmp(PQgetvalue(res,0,0),"1")!=0)`
`572`	`572`	`pg_fatal("Only the install user can be defined in the new cluster.");`
`573`	`573`
`574`	`574`	`PQclear(res);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit106f26a

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/check.c`

0 commit comments