forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0fcc2de
committed
In clog_redo(), don't set XactCtl->shared->latest_page_number.
The comment is no longer accurate, and hasn't been entirely accuratesince Hot Standby was introduced. The original idea here was thatStartupCLOG() wouldn't be called until the end of recovery andtherefore this value would be uninitialized when this code is reached,but Hot Standby made that true only when hot_standby=off, and commit1f113ab means that this value is nowalways initialized before replay even starts.The original purpose of this code was to bypass the sanity checkin SimpleLruTruncate(), which will no longer occur: now, if somethingis wrong, that sanity check might trip during recovery. That'sprobably a good thing, because in the current code baselatest_page_number should always be initialized and therefore weexpect that the sanity check should pass. If it doesn't, somethinghas gone wrong, and complaining about it is appropriate.Patch by me, reviewed by Heikki Linnakangas.Discussion:http://postgr.es/m/CA+TgmoZYig9+AQodhF5sRXuKkJ=RgFDugLr3XX_dz_F-p=TwTg@mail.gmail.com1 parent662affc commit0fcc2de
1 file changed
+0
-6
lines changedLines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | 1014 | | |
1021 | 1015 | | |
1022 | 1016 | | |
| |||
0 commit comments
Comments
(0)