Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0fc9434

Browse files
committed
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED.
Commitdd428c7 added dbId and tsId to the xl_xact_commit struct but missedthat prepared transaction commits reuse that struct. Fix that.Because those fields were left unitialized, replaying a commit prepared WALrecord in a hot standby node would fail to remove the relcache init file.That can lead to "could not open file" errors on the standby. Relcache initfile only needs to be removed when a system table/index is rewritten in thetransaction using two phase commit, so that should be rare in practice. InHEAD, the incorrect dbId/tsId values are also used for filtering in logicalreplication code, causing the transaction to always be filtered out.Analysis and fix by Andres Freund. Backpatch to 9.0 where hot standby wasintroduced.
1 parent9fb8cd2 commit0fc9434

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

‎src/backend/access/transam/twophase.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2035,9 +2035,13 @@ RecordTransactionCommitPrepared(TransactionId xid,
20352035

20362036
/* Emit the XLOG commit record */
20372037
xlrec.xid=xid;
2038-
xlrec.crec.xact_time=GetCurrentTimestamp();
2038+
20392039
xlrec.crec.xinfo=initfileinval ?XACT_COMPLETION_UPDATE_RELCACHE_FILE :0;
2040-
xlrec.crec.nmsgs=0;
2040+
2041+
xlrec.crec.dbId=MyDatabaseId;
2042+
xlrec.crec.tsId=MyDatabaseTableSpace;
2043+
2044+
xlrec.crec.xact_time=GetCurrentTimestamp();
20412045
xlrec.crec.nrels=nrels;
20422046
xlrec.crec.nsubxacts=nchildren;
20432047
xlrec.crec.nmsgs=ninvalmsgs;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp