NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0fc68c8

committed

Fix issue in recovery test 041_checkpoint_at_promote

The phase of the test waiting for a restartpoint to complete was notworking as intended, due to a log_contains() call incorrectlywritten.The problem reported by the author could be simply reproduced byremoving the injection_points_wakeup() call: the test succeeds ratherthan waiting for the restartpoint completion. In most cases, therestartpoint completion is fast enough that the test offered the wantedcoverage. On slow machines, it could have become unreliable.Oversight in6782709.Author: Nitin JadhavDiscussion:https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.comBackpatch-through: 17

1 parent5b94e27 commit0fc68c8Copy full SHA for 0fc68c8

File tree

1 file changed

-1

lines changed

src/test/recovery/t
- 041_checkpoint_at_promote.pl

1 file changed

-1

lines changed

`‎src/test/recovery/t/041_checkpoint_at_promote.pl`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@`
`110`	`110`	`my$checkpoint_complete = 0;`
`111`	`111`	`foreachmy$i (0 .. 10 *$PostgreSQL::Test::Utils::timeout_default)`
`112`	`112`	`{`
`113`		`-if ($node_standby->log_contains("restartpoint complete"),$logstart)`
	`113`	`+if ($node_standby->log_contains("restartpoint complete",$logstart))`
`114`	`114`	`{`
`115`	`115`	`$checkpoint_complete = 1;`
`116`	`116`	`last;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0fc68c8

File tree

1 file changed

1 file changed

`‎src/test/recovery/t/041_checkpoint_at_promote.pl`

0 commit comments