NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0fa6884

committed

Fix sign-compare warnings in pg_iovec.h.

The code in question (pg_preadv() and pg_pwritev()) has been aroundfor a while, but commit15c9ac3 moved it to a header file. Ifthird-party code that includes this header file is built with-Wsign-compare on a system without preadv() or pwritev(), warningsensue. This commit fixes said warnings by casting the result ofpg_pread()/pg_pwrite() to size_t, which should be safe because wewill have already checked for a negative value.Author: Wolfgang WaltherDiscussion:https://postgr.es/m/16989737-1aa8-48fd-8dfe-b7ada06509ab%40technowledgy.deBackpatch-through: 17

1 parentcaca6d8 commit0fa6884Copy full SHA for 0fa6884

File tree

1 file changed

-2

lines changed

src/include/port
- pg_iovec.h

1 file changed

-2

lines changed

`‎src/include/port/pg_iovec.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ pg_preadv(int fd, const struct iovec *iov, int iovcnt, off_t offset)`
`68`	`68`	`}`
`69`	`69`	`sum+=part;`
`70`	`70`	`offset+=part;`
`71`		`-if (part<iov[i].iov_len)`
	`71`	`+if ((size_t)part<iov[i].iov_len)`
`72`	`72`	`returnsum;`
`73`	`73`	`}`
`74`	`74`	`returnsum;`
`@@ -107,7 +107,7 @@ pg_pwritev(int fd, const struct iovec *iov, int iovcnt, off_t offset)`
`107`	`107`	`}`
`108`	`108`	`sum+=part;`
`109`	`109`	`offset+=part;`
`110`		`-if (part<iov[i].iov_len)`
	`110`	`+if ((size_t)part<iov[i].iov_len)`
`111`	`111`	`returnsum;`
`112`	`112`	`}`
`113`	`113`	`returnsum;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0fa6884

File tree

1 file changed

1 file changed

`‎src/include/port/pg_iovec.h`

0 commit comments