Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0f574a7

Browse files
committed
Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seconds.
There seems to be some considerable imprecision in the timing of -Pprogress reports. Nominally each thread ought to produce 2 reportsin this test, but about 10% of the time we only get one, and 1% ofthe time we get three, as per buildfarm results so far. Pendingfurther investigation, treat the last case as a "pass". (I, tgl,am suspicious that this still might not be lax enough, now that it'sobvious that the behavior is load-dependent; but there's not yetbuildfarm evidence to confirm that suspicion.)Fabien CoelhoDiscussion:https://postgr.es/m/26654.1505232433@sss.pgh.pa.us
1 parent5d3cad5 commit0f574a7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

‎src/bin/pgbench/t/001_pgbench_with_server.pl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,8 +462,9 @@ sub check_pgbench_logs
462462
[qr{vacuum},qr{progress: 1\b} ],
463463
'pgbench progress');
464464

465-
# $nthreads threads, 2 seconds, sometimes only one aggregated line is written
466-
check_pgbench_logs('001_pgbench_log_1',$nthreads, 1, 2,
465+
# $nthreads threads, 2 seconds, but due to timing imprecision we might get
466+
# only 1 or as many as 3 progress reports per thread.
467+
check_pgbench_logs('001_pgbench_log_1',$nthreads, 1, 3,
467468
qr{^\d+\d{1,2}\d+\d+\d+\d+\d+\d+\d+\d+\d+$});
468469

469470
# with sampling rate

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp