Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0f3cdf8

Browse files
committed
Make pg_partition_tree return no rows on unsupported and undefined objects
The function was tweaked so as it returned one row full of NULLs whenworking on an unsupported relkind or an undefined object as ofcc53123,and after discussion with Amit and Álvaro it looks more natural to makeit return no rows.Author: Michael PaquierReviewed-by: Álvaro Herrera, Amit LangoteDiscussion:https://postgr.es/m/20190227184808.GA17357@alvherre.pgsql
1 parent2536551 commit0f3cdf8

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

‎src/backend/utils/adt/partitionfuncs.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ pg_partition_tree(PG_FUNCTION_ARGS)
6969
FuncCallContext*funcctx;
7070
ListCell**next;
7171

72-
if (!check_rel_can_be_partition(rootrelid))
73-
PG_RETURN_NULL();
74-
7572
/* stuff done only on the first call of the function */
7673
if (SRF_IS_FIRSTCALL())
7774
{
@@ -82,6 +79,9 @@ pg_partition_tree(PG_FUNCTION_ARGS)
8279
/* create a function context for cross-call persistence */
8380
funcctx=SRF_FIRSTCALL_INIT();
8481

82+
if (!check_rel_can_be_partition(rootrelid))
83+
SRF_RETURN_DONE(funcctx);
84+
8585
/* switch to memory context appropriate for multiple function calls */
8686
oldcxt=MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);
8787

‎src/test/regress/expected/partition_info.out

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ SELECT * FROM pg_partition_tree(NULL);
99
SELECT * FROM pg_partition_tree(0);
1010
relid | parentrelid | isleaf | level
1111
-------+-------------+--------+-------
12-
| | |
13-
(1 row)
12+
(0 rows)
1413

1514
SELECT pg_partition_root(NULL);
1615
pg_partition_root
@@ -163,14 +162,12 @@ CREATE MATERIALIZED VIEW ptif_test_matview AS SELECT 1;
163162
SELECT * FROM pg_partition_tree('ptif_test_view');
164163
relid | parentrelid | isleaf | level
165164
-------+-------------+--------+-------
166-
| | |
167-
(1 row)
165+
(0 rows)
168166

169167
SELECT * FROM pg_partition_tree('ptif_test_matview');
170168
relid | parentrelid | isleaf | level
171169
-------+-------------+--------+-------
172-
| | |
173-
(1 row)
170+
(0 rows)
174171

175172
SELECT pg_partition_root('ptif_test_view');
176173
pg_partition_root

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp