forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0ec3e13
committed
Fix tab completion of "SET variable TO|=" to not offer bogus completions.
Don't think that the context "UPDATE tab SET var =" is a GUC-settingcommand.If we have "SET var =" but the "var" is not a known GUC variable,don't offer any completions. The most likely explanation is thatwe've misparsed the context and it's not really a GUC-setting command.Per gripe from Ken Tanzer. Back-patch to 9.6. The issue existsfurther back, but before 9.6 the code looks very different and itdoesn't actually know whether the "var" name matches anything,so I desisted from trying to fix it.Discussion:https://postgr.es/m/CAD3a31XpXzrZA9TT3BqLSHghdTK+=cXjNCE+oL2Zn4+oWoc=qA@mail.gmail.com1 parent4d6603f commit0ec3e13
1 file changed
+26
-13
lines changedLines changed: 26 additions & 13 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3362 | 3362 |
| |
3363 | 3363 |
| |
3364 | 3364 |
| |
3365 |
| - | |
3366 |
| - | |
| 3365 | + | |
| 3366 | + | |
| 3367 | + | |
| 3368 | + | |
| 3369 | + | |
| 3370 | + | |
| 3371 | + | |
3367 | 3372 |
| |
3368 | 3373 |
| |
3369 | 3374 |
| |
| |||
3381 | 3386 |
| |
3382 | 3387 |
| |
3383 | 3388 |
| |
3384 |
| - | |
| 3389 | + | |
| 3390 | + | |
| 3391 | + | |
| 3392 | + | |
| 3393 | + | |
| 3394 | + | |
3385 | 3395 |
| |
3386 |
| - | |
| 3396 | + | |
| 3397 | + | |
| 3398 | + | |
3387 | 3399 |
| |
3388 |
| - | |
3389 |
| - | |
3390 |
| - | |
3391 |
| - | |
3392 |
| - | |
3393 |
| - | |
3394 |
| - | |
3395 |
| - | |
| 3400 | + | |
| 3401 | + | |
| 3402 | + | |
| 3403 | + | |
| 3404 | + | |
| 3405 | + | |
| 3406 | + | |
| 3407 | + | |
| 3408 | + | |
3396 | 3409 |
| |
3397 |
| - | |
3398 | 3410 |
| |
| 3411 | + | |
3399 | 3412 |
| |
3400 | 3413 |
| |
3401 | 3414 |
| |
|
0 commit comments
Comments
(0)