Commit0e497ea

committed

mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for msvc

While mingw would otherwise fall back to__attribute__((visibility("default"))), that appears to only work as long asno symbols are declared with __declspec(dllexport). But we can end up withsome, e.g. plpython's Py_Init.It's quite possible we should do the same for cygwin, but I don't have a testenvironment for that...Discussion:http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.deDiscussion:http://postgr.es/m/20220928025242.ugf7t5ugxxgmkraa@awork3.anarazel.de

1 parent4e4f7b9 commit0e497eaCopy full SHA for 0e497ea

File tree

-4

lines changed

-4

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,11 @@`
`49`	`49`	`#endif`
`50`	`50`
`51`	`51`	`/*`
`52`		`- * Under MSVC, functions exported by a loadable module must be marked`
`53`		`- * "dllexport". Other compilers don't need that.`
	`52`	`+ * Functions exported by a loadable module must be marked "dllexport".`
	`53`	`+ *`
	`54`	`+ * While mingw would otherwise fall back to`
	`55`	`+ * __attribute__((visibility("default"))), that appears to only work as long`
	`56`	`+ * as no symbols are declared with __declspec(dllexport). But we can end up`
	`57`	`+ * with some, e.g. plpython's Py_Init.`
`54`	`58`	`*/`
`55`		`-#ifdef_MSC_VER`
`56`	`59`	`#definePGDLLEXPORT __declspec (dllexport)`
`57`		`-#endif`

Comments

(0)