NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0e033f5

committed

Fix a memory leak in dumping functions with TRANSFORMs

The gneration of the dump clause for functions with TRANSFORMcalls would leak the memory for holding the result of the Oidarray parsing. Fix by freeing.While in there, switch to using pg_malloc instead of palloc inorder to be consistent with the rest of the file.Author: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>Reviewed-by: Daniel Gustafsson <daniel@yesql.se>Discussion:https://postgr.es/m/baf1ae4511288e5b421f41e79a3df1a0@postgrespro.ru

1 parent9df2a4b commit0e033f5Copy full SHA for 0e033f5

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12531,7 +12531,7 @@ dumpFunc(Archive fout, const FuncInfo finfo)`
`12531`	`12531`
`12532`	`12532`	`if (*protrftypes)`
`12533`	`12533`	`{`
`12534`		`-Oid typeids =palloc(FUNC_MAX_ARGS sizeof(Oid));`
	`12534`	`+Oid typeids =pg_malloc(FUNC_MAX_ARGS sizeof(Oid));`
`12535`	`12535`	`inti;`
`12536`	`12536`
`12537`	`12537`	`appendPQExpBufferStr(q, " TRANSFORM ");`
`@@ -12543,6 +12543,8 @@ dumpFunc(Archive fout, const FuncInfo finfo)`
`12543`	`12543`	`appendPQExpBuffer(q, "FOR TYPE %s",`
`12544`	`12544`	`getFormattedTypeName(fout, typeids[i], zeroAsNone));`
`12545`	`12545`	`}`
	`12546`	`+`
	`12547`	`+free(typeids);`
`12546`	`12548`	`}`
`12547`	`12549`
`12548`	`12550`	`if (prokind[0] == PROKIND_WINDOW)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0e033f5

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments