NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0dd094c

committed

Remove unused ParallelWorkerInfo.pid field

The pid was originally used in error context of messages propagatedfrom parallel workers, but commit292794f removed that. If the needarises in the future, you can also get the pid with"shm_mq_get_sender(pcxt->worker[i].error_mqh)->pid".

1 parent8545b28 commit0dd094cCopy full SHA for 0dd094c

File tree

2 files changed

-24

lines changed

src
- backend/access/transam
  - parallel.c
- include/access
  - parallel.h

2 files changed

-24

lines changed

`‎src/backend/access/transam/parallel.c`

Lines changed: 0 additions & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -1131,16 +1131,6 @@ HandleParallelMessage(ParallelContext *pcxt, int i, StringInfo msg)`
`1131`	`1131`
`1132`	`1132`	`switch (msgtype)`
`1133`	`1133`	`{`
`1134`		`-casePqMsg_BackendKeyData:`
`1135`		`-{`
`1136`		`-int32pid=pq_getmsgint(msg,4);`
`1137`		`-`
`1138`		`-(void)pq_getmsgint(msg,4);/* discard cancel key */`
`1139`		`-(void)pq_getmsgend(msg);`
`1140`		`-pcxt->worker[i].pid=pid;`
`1141`		`-break;`
`1142`		`-}`
`1143`		`-`
`1144`	`1134`	`casePqMsg_ErrorResponse:`
`1145`	`1135`	`casePqMsg_NoticeResponse:`
`1146`	`1136`	`{`
`@@ -1304,7 +1294,6 @@ ParallelWorkerMain(Datum main_arg)`
`1304`	`1294`	`char*relmapperspace;`
`1305`	`1295`	`char*uncommittedenumsspace;`
`1306`	`1296`	`char*clientconninfospace;`
`1307`		`-StringInfoDatamsgbuf;`
`1308`	`1297`	`char*session_dsm_handle_space;`
`1309`	`1298`	`Snapshottsnapshot;`
`1310`	`1299`	`Snapshotasnapshot;`
`@@ -1369,18 +1358,6 @@ ParallelWorkerMain(Datum main_arg)`
`1369`	`1358`	`pq_set_parallel_leader(fps->parallel_leader_pid,`
`1370`	`1359`	`fps->parallel_leader_proc_number);`
`1371`	`1360`
`1372`		`-/*`
`1373`		`- * Send a BackendKeyData message to the process that initiated parallelism`
`1374`		`- * so that it has access to our PID before it receives any other messages`
`1375`		`- * from us. Our cancel key is sent, too, since that's the way the`
`1376`		`- * protocol message is defined, but it won't actually be used for anything`
`1377`		`- * in this case.`
`1378`		`- */`
`1379`		`-pq_beginmessage(&msgbuf,PqMsg_BackendKeyData);`
`1380`		`-pq_sendint32(&msgbuf, (int32)MyProcPid);`
`1381`		`-pq_sendint32(&msgbuf, (int32)MyCancelKey);`
`1382`		`-pq_endmessage(&msgbuf);`
`1383`		`-`
`1384`	`1361`	`/*`
`1385`	`1362`	`* Hooray! Primary initialization is complete. Now, we need to set up our`
`1386`	`1363`	`* backend-local state to match the original backend.`

`‎src/include/access/parallel.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ typedef struct ParallelWorkerInfo`
`26`	`26`	`{`
`27`	`27`	`BackgroundWorkerHandle*bgwhandle;`
`28`	`28`	`shm_mq_handle*error_mqh;`
`29`		`-int32pid;`
`30`	`29`	`}ParallelWorkerInfo;`
`31`	`30`
`32`	`31`	`typedefstructParallelContext`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0dd094c

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/parallel.c`

`‎src/include/access/parallel.h`

0 commit comments