forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0dc4019
committed
Work around spurious compiler warning in inet operators
gcc 12+ has complaints like the following:../../../../../pgsql/src/backend/utils/adt/network.c: In function 'inetnot':../../../../../pgsql/src/backend/utils/adt/network.c:1893:34: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 1893 | pdst[nb] = ~pip[nb]; | ~~~~~~~~~^~~~~~~~~~../../../../../pgsql/src/include/utils/inet.h:27:23: note: at offset -1 into destination object 'ipaddr' of size 16 27 | unsigned char ipaddr[16]; /* up to 128 bits of address */ | ^~~~~~../../../../../pgsql/src/include/utils/inet.h:27:23: note: at offset -1 into destination object 'ipaddr' of size 16This is due to a compiler bug:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104986It has been a year since the bug has been reported without getting fixed. Asthe warnings are verbose and use of gcc 12 is becoming more common, it seemsworth working around the bug. Particularly because a simple reformulation ofthe loop condition fixes the issue and isn't any less readable.Author: Tom Lane <tgl@sss.pgh.pa.us>Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/144536.1648326206@sss.pgh.pa.usBackpatch: 11-1 parent6a9229d commit0dc4019
1 file changed
+5
-5
lines changedLines changed: 5 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1866 | 1866 |
| |
1867 | 1867 |
| |
1868 | 1868 |
| |
1869 |
| - | |
| 1869 | + | |
1870 | 1870 |
| |
1871 | 1871 |
| |
1872 | 1872 |
| |
| |||
1898 | 1898 |
| |
1899 | 1899 |
| |
1900 | 1900 |
| |
1901 |
| - | |
| 1901 | + | |
1902 | 1902 |
| |
1903 | 1903 |
| |
1904 | 1904 |
| |
| |||
1930 | 1930 |
| |
1931 | 1931 |
| |
1932 | 1932 |
| |
1933 |
| - | |
| 1933 | + | |
1934 | 1934 |
| |
1935 | 1935 |
| |
1936 | 1936 |
| |
| |||
1955 | 1955 |
| |
1956 | 1956 |
| |
1957 | 1957 |
| |
1958 |
| - | |
| 1958 | + | |
1959 | 1959 |
| |
1960 | 1960 |
| |
1961 | 1961 |
| |
| |||
2039 | 2039 |
| |
2040 | 2040 |
| |
2041 | 2041 |
| |
2042 |
| - | |
| 2042 | + | |
2043 | 2043 |
| |
2044 | 2044 |
| |
2045 | 2045 |
| |
|
0 commit comments
Comments
(0)