Commit0d5a3d7

committed

Remove NULL dereference from RenameRelationInternal().

Defect in last week's commitaac2c9b,per Coverity. Reaching this would need catalog corruption. Back-patchto v12, like that commit.

1 parente933978 commit0d5a3d7Copy full SHA for 0d5a3d7

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4132,9 +4132,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal, bo`
`4132`	`4132`	`relrelation = table_open(RelationRelationId, RowExclusiveLock);`
`4133`	`4133`
`4134`	`4134`	`reltup = SearchSysCacheLockedCopy1(RELOID, ObjectIdGetDatum(myrelid));`
`4135`		`-otid = reltup->t_self;`
`4136`	`4135`	`if (!HeapTupleIsValid(reltup))/* shouldn't happen */`
`4137`	`4136`	`elog(ERROR, "cache lookup failed for relation %u", myrelid);`
	`4137`	`+otid = reltup->t_self;`
`4138`	`4138`	`relform = (Form_pg_class) GETSTRUCT(reltup);`
`4139`	`4139`
`4140`	`4140`	`if (get_relname_relid(newrelname, namespaceId) != InvalidOid)`

Comments

(0)