forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0ca6bda
committed
Get rid of bogus dependency on typcategory in to_json() and friends.
These functions were relying on typcategory to identify arrays andcomposites, which is not reliable and not the normal way to do it.Using typcategory to identify boolean, numeric types, and json itself isalso pretty questionable, though the code in those cases didn't seem to beat risk of anything worse than wrong output. Instead, use the standardlsyscache functions to identify arrays and composites, and rely on a directcheck of the type OID for the other cases.In HEAD, also be sure to look through domains so that a domain is treatedthe same as its base type for conversions to JSON. However, this is asmall behavioral change; given the lack of field complaints, we won'tback-patch it.In passing, refactor so that there's only one copy of the code that decideswhich conversion strategy to apply, not multiple copies that could (andhave) gotten out of sync.1 parentf1d8dd3 commit0ca6bda
1 file changed
+181
-229
lines changed0 commit comments
Comments
(0)