forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0c6f4f9
committed
Reduce length of GIN predicate locking isolation test suite
Isolation test suite of GIN predicate locking was criticized for being too slow,especially under Valgrind. This commit is intended to accelerate it. Tests aresimplified in the following ways. 1) Amount of data is reduced. We're now close to the minimal amount of data, which produces at least one posting tree and at least two pages of entry tree. 2) Three isolation tests are merged into one. 3) Only one tuple is queried from posting tree. So, locking of index is the same, but tuple locks are not propagated to relation lock. Also, it is faster. 4) Test cases itself are simplified. Now each test case run just one INSERT and one SELECT involving GIN, which either conflict or not.Discussion:https://postgr.es/m/20181204000740.ok2q53nvkftwu43a%40alap3.anarazel.deReported-by: Andres FreundTested-by: Andrew DunstanAuthor: Alexander KorotkovBackpatch-through: 111 parentae4472c commit0c6f4f9
File tree
7 files changed
+320
-768
lines changed- src/test/isolation
- expected
- specs
7 files changed
+320
-768
lines changedLines changed: 0 additions & 30 deletions
This file was deleted.
Lines changed: 0 additions & 15 deletions
This file was deleted.
0 commit comments
Comments
(0)