NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0b8e0bf

committed

Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait.

In commit2ffa869 we made pg_ctl recognize an environment variablePGCTLTIMEOUT to set the default timeout for starting and stopping thepostmaster. However, pg_regress uses pg_ctl only for the "stop" end ofthat; it has bespoke code for starting the postmaster, and that code hashistorically had a hard-wired 60-second timeout. Further buildfarmexperience says it'd be a good idea if that timeout were also controlledby PGCTLTIMEOUT, so let's make it so. Like the previous patch, back-patchto all active branches.Discussion: <13969.1461191936@sss.pgh.pa.us>

1 parentbe27544 commit0b8e0bfCopy full SHA for 0b8e0bf

File tree

1 file changed

+21

-6

lines changed

src/test/regress
- pg_regress.c

1 file changed

+21

-6

lines changed

`‎src/test/regress/pg_regress.c`

Lines changed: 21 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2185,6 +2185,8 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2185`	`2185`	`if (temp_instance)`
`2186`	`2186`	`{`
`2187`	`2187`	`FILE*pg_conf;`
	`2188`	`+constchar*env_wait;`
	`2189`	`+intwait_seconds;`
`2188`	`2190`
`2189`	`2191`	`/*`
`2190`	`2192`	`* Prepare the temp instance`
`@@ -2334,11 +2336,23 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2334`	`2336`	`}`
`2335`	`2337`
`2336`	`2338`	`/*`
`2337`		`- * Wait till postmaster is able to accept connections (normally only a`
`2338`		`- * second or so, but Cygwin is reportedly much slower). Don't wait`
`2339`		`- * forever, however.`
	`2339`	`+ * Wait till postmaster is able to accept connections; normally this`
	`2340`	`+ * is only a second or so, but Cygwin is reportedly much slower, and`
	`2341`	`+ * test builds using Valgrind or similar tools might be too. Hence,`
	`2342`	`+ * allow the default timeout of 60 seconds to be overridden from the`
	`2343`	`+ * PGCTLTIMEOUT environment variable.`
`2340`	`2344`	`*/`
`2341`		`-for (i=0;i<60;i++)`
	`2345`	`+env_wait=getenv("PGCTLTIMEOUT");`
	`2346`	`+if (env_wait!=NULL)`
	`2347`	`+{`
	`2348`	`+wait_seconds=atoi(env_wait);`
	`2349`	`+if (wait_seconds <=0)`
	`2350`	`+wait_seconds=60;`
	`2351`	`+}`
	`2352`	`+else`
	`2353`	`+wait_seconds=60;`
	`2354`	`+`
	`2355`	`+for (i=0;i<wait_seconds;i++)`
`2342`	`2356`	`{`
`2343`	`2357`	`/* Done if psql succeeds */`
`2344`	`2358`	`if (system(buf2)==0)`
`@@ -2359,9 +2373,10 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2359`	`2373`
`2360`	`2374`	`pg_usleep(1000000L);`
`2361`	`2375`	`}`
`2362`		`-if (i >=60)`
	`2376`	`+if (i >=wait_seconds)`
`2363`	`2377`	`{`
`2364`		`-fprintf(stderr,_("\n%s: postmaster did not respond within 60 seconds\nExamine %s/log/postmaster.log for the reason\n"),progname,outputdir);`
	`2378`	`+fprintf(stderr,_("\n%s: postmaster did not respond within %d seconds\nExamine %s/log/postmaster.log for the reason\n"),`
	`2379`	`+progname,wait_seconds,outputdir);`
`2365`	`2380`
`2366`	`2381`	`/*`
`2367`	`2382`	`* If we get here, the postmaster is probably wedged somewhere in`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0b8e0bf

File tree

1 file changed

1 file changed

`‎src/test/regress/pg_regress.c`

0 commit comments