Commit0b7ba3d

committed

pgstatindex: Insert some casts to prevent overflow.

This could cause hash indexes to report greater than 100% free space.Ashutosh Sharma, reviewed by Amit KapilaDiscussion:http://postgr.es/m/CAE9k0PnCKfg-ZK1CwGZJPF1yKcG2A=GUgC3BMdNMzLAXVOo4Eg@mail.gmail.com

1 parentec99dd5 commit0b7ba3dCopy full SHA for 0b7ba3d

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -687,13 +687,14 @@ pgstathashindex(PG_FUNCTION_ARGS)`
`687`	`687`	`index_close(rel,AccessShareLock);`
`688`	`688`
`689`	`689`	`/* Count unused pages as free space. */`
`690`		`-stats.free_space+=stats.unused_pages*stats.space_per_page;`
	`690`	`+stats.free_space+=(uint64)stats.unused_pages*stats.space_per_page;`
`691`	`691`
`692`	`692`	`/*`
`693`	`693`	`* Total space available for tuples excludes the metapage and the bitmap`
`694`	`694`	`* pages.`
`695`	`695`	`*/`
`696`		`-total_space= (nblocks- (stats.bitmap_pages+1))*stats.space_per_page;`
	`696`	`+total_space= (uint64) (nblocks- (stats.bitmap_pages+1))*`
	`697`	`+stats.space_per_page;`
`697`	`698`
`698`	`699`	`if (total_space==0)`
`699`	`700`	`free_percent=0.0;`

Comments

(0)