NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0b49642

committed

pg_standby: Avoid writing one byte beyond the end of the buffer.

Previously, read() might have returned a length equal to the bufferlength, and then the subsequent store to buf[len] would write azero-byte one byte past the end. This doesn't seem likely to bea security issue, but there's some chance it could result inpg_standby misbehaving.Spotted by Coverity; patch by Michael Paquier, reviewed by me.

1 parent6cfd508 commit0b49642Copy full SHA for 0b49642

File tree

1 file changed

-1

lines changed

contrib/pg_standby
- pg_standby.c

1 file changed

-1

lines changed

`‎contrib/pg_standby/pg_standby.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ CheckForExternalTrigger(void)`
`418`	`418`	`return;`
`419`	`419`	`}`
`420`	`420`
`421`		`-if ((len=read(fd,buf,sizeof(buf)))<0)`
	`421`	`+if ((len=read(fd,buf,sizeof(buf)-1))<0)`
`422`	`422`	`{`
`423`	`423`	`fprintf(stderr,"WARNING: could not read \"%s\": %s\n",`
`424`	`424`	`triggerPath,strerror(errno));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0b49642

File tree

1 file changed

1 file changed

`‎contrib/pg_standby/pg_standby.c`

0 commit comments