NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0ae05c1

committed

Fix query result leak during binary upgrade

9a974cb moved the query in binary_upgrade_set_pg_class_oids to theouter level, but left the PQclear and query buffer destruction in theis_index conditional.353708e fixed the leak of the query bufferbut left the PGresult leak. This moves clearing the result to the outerlevel ensuring that it will be called.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.seBackpatch-through: v15

1 parent315661e commit0ae05c1Copy full SHA for 0ae05c1

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5127,8 +5127,6 @@ binary_upgrade_set_pg_class_oids(Archive *fout,`
`5127`	`5127`	`"SELECT pg_catalog.binary_upgrade_set_next_index_relfilenode('%u'::pg_catalog.oid);\n",`
`5128`	`5128`	`toast_index_relfilenumber);`
`5129`	`5129`	`}`
`5130`		`-`
`5131`		`-PQclear(upgrade_res);`
`5132`	`5130`	`}`
`5133`	`5131`	`else`
`5134`	`5132`	`{`
`@@ -5141,6 +5139,8 @@ binary_upgrade_set_pg_class_oids(Archive *fout,`
`5141`	`5139`	`relfilenumber);`
`5142`	`5140`	`}`
`5143`	`5141`
	`5142`	`+PQclear(upgrade_res);`
	`5143`	`+`
`5144`	`5144`	`appendPQExpBufferChar(upgrade_buffer, '\n');`
`5145`	`5145`
`5146`	`5146`	`destroyPQExpBuffer(upgrade_query);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0ae05c1

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments