NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0ac1fed

committed

Fix missing PQclear() in libpqrcv_endstreaming().

This omission leaked one PGresult per WAL streaming cycle, which possiblywould never be enough to notice in the real world, but it's still a leak.Per Coverity. Back-patch to 9.3 where the error was introduced.

1 parente44735c commit0ac1fedCopy full SHA for 0ac1fed

File tree

1 file changed

-0

lines changed

src/backend/replication/libpqwalreceiver
- libpqwalreceiver.c

1 file changed

-0

lines changed

`‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,7 @@ libpqrcv_endstreaming(TimeLineID *next_tli)`
`252`	`252`	`ereport(ERROR,`
`253`	`253`	`(errmsg("error reading result of streaming command: %s",`
`254`	`254`	`PQerrorMessage(streamConn))));`
	`255`	`+PQclear(res);`
`255`	`256`
`256`	`257`	`/* Verify that there are no more results */`
`257`	`258`	`res=PQgetResult(streamConn);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0ac1fed

File tree

1 file changed

1 file changed

`‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c`

0 commit comments